brandizzi/liferay-portal — pull request #1 by Ithildir (2013-12-04 15:00:39+00:00)
Title: LPS-42759

Hi Adam! I'm Andrea of SMC Treviso, Italy. Nice to meet you!

I found a problem (LPS-42759) regarding the `liferay-ui:input-time` taglib and 24-hour locales, which is related to LPS-39969. You worked on that issue, and that's why I'm writing to you :blush:

The problem I found seems to depend on the different ways that taglib is used in the portal:
* where the taglib is used directly in a portlet page, the `hourValue` and `amPmValue` parameters are always equal to the `HOUR` and `AM_PM` values of a java.util.Calendar, no matter if the current locale has 24-hour or 12-hour format;
* where the taglib is used inside of other taglibs, those two parameters have values equal to `HOUR` and `AM_PM` of a Calendar only if the current locale has 12-hour format. With 24-hour locales, instead, `hourValue` is equal to the `HOUR_OF_DAY` value and `amPmValue` is always `Calendar.AM`.

With 24-hour format locales, the line you added for LPS-39969 sets the `AM_PM` value of the `Calendar` object to `Calendar.AM`, even if the time is after 12pm. Moreover, the CalendarFactoryUtil method used in the taglib code should expect a 24-hour format (and so maybe parameter names should be changed), because internally it uses GregorianCalendar, which in turns requires a `HOUR_OF_DAY` value.

Hope to be helpful and that my PR is ok :blush: