NREL/OpenStudio — pull request #685 by mbadams5 (2013-12-04 19:37:04+00:00)
Title: Update FanOnOff

FanOnOff had various bugs in its implementation.

When the FanOnOff is removed, previously it would not remove() the
curves associated with it due to missing children() function.

FanOnOff used inherited addToNode() implementation, which allowed it
to be added to an AirLoopHVAC. This is not possible in EnergyPlus.
FanOnOff can only be added to a containing HVAC Component, such as
Unitary, ZoneHVAC, etc.

The constructor required two curves to be passed into it but then
created two curves within the constructor, never using the passed in
curves. This has been changed.

FanOnOff within EnergyPlus does not require the two curves, which allow
the change from constant speed to multi speed. However, the current
OpenStudio implementation requires these curves thus a new overloaded
constructor is made which creates constant curves and does not require
the curves to be passed into the constructor. This allows FanOnOff to
be modeled as constant speed.

The unit tests for FanOnOff are also updated to have better test
coverage.

@kbenne @asparke2