bradyvercher/rocketeer — pull request #2 by blobaugh (2013-12-03 16:09:05+00:00)
Title: Removed deactivation alterations of Jetpack

Howdy Brady! Saw your mention on WP Tavern ( http://www.wptavern.com/easier-way-to-enable-or-disable-jetpack-modules-with-rocketeer ). Love the plugin! Thanks a ton for building it. I did notice that you blew away Jetpack's deactivation and put your own in place of it. What is the thought process that you had for that? In general it is not recommended to remove Jetpack's deactivation process as it is doing far more than you may think. There is a lot of cleanup that happens under the hood both with your site and on WordPress.com. This pull request restores that functionality.

I find it interesting that you put the Heartbeat stuff in your deactivate. That was a good catch. I just noticed myself last week that the disconnect was put in an awkward location inside of Jetpack and moved it to the deactivate method. You should see that in a future release.