CONNECT-Solution/CONNECT — pull request #628 by christophermay07 (2013-12-04 02:45:04+00:00)
Title: CONN-677

** FIXES **

Converted DataHandler to use URL instead of FileInputStream:
CONNECTCoreLib
gov.hhs.fha.nhinc.largefile.LargeFileUtils, line 209

Fixed by calling "free()" for Blob in a finally block in the parent function:
AuditRepositoryCore
gov.hhs.fha.nhinc.auditrepository.nhinc.AuditRepositoryOrchImpl, line 297

Fixed by calling "close()" for InputStream in a finally block:
CONNECTCoreLib
gov.hhs.fha.nhinc.largefile.LargeFileUtils, line 251

Fixed by calling "close()" for Writer in a finally block:
FTATransferAdapterEJB
gov.hhs.fha.nhinc.fta.NotificationImpl, line 124

Deleted a commented-out function that covered the following lines:
PolicyEngineCore
gov.hhs.fha.nhinc.policyengine.adapter.pip.PatientConsentDocumentBuilderHelper, line 1033
gov.hhs.fha.nhinc.policyengine.adapter.pip.PatientConsentDocumentBuilderHelper, line 1022

** NON-FIXES **

The following instances were flagged incorrectly (they are closing the stream as expected):
CONNECTCoreLib
gov.hhs.fha.nhinc.properties.PropertyFileDAO, line 80
gov.hhs.fha.nhinc.properties.PropertyFileManager, line 68
gov.hhs.fha.nhinc.properties.PropertyAccessorFileUtilities, line 122
gov.hhs.fha.nhinc.util.StringUtil, line 55

The following instance is intended to be used with SOAP requests, where any stream would be closed before calling this function (at the moment, it is only used in test classes, where the "stream" is either null or a String):
DirectCore
gov.hhs.fha.nhinc.direct.MimeMessageBuilder, line 211