brianchandotcom/liferay-plugins — pull request #2396 by lipusz (2013-12-02 17:40:22+00:00)
Title: [STORY | Chat] LPS-42584 As a Portal Administrator, I would like the ability to define which Social Relation types are allowed for Chat portlet

Hi Brian,

Nate encouraged me to send this pull directly to you https://github.com/natecavanaugh/liferay-plugins/pull/189#issuecomment-29636881 instead of him.

I tried to sum-up my proposed changes in the description of https://issues.liferay.com/browse/LPS-42584. This ticket was opened as a result of an Engineering thread. You can find the link in a comment at the LPS.

=== About my changes (in order of commits)
1 | LPS-42472 Autogenerated (missing) | 7417be0

I ran "ant build-service" for Chat before making any changes in order to separate the autogenerated stuffs. I've found that https://issues.liferay.com/browse/LPS-42472 was the last one in master that touched persistence_impl.ftl: liferay@c983514 and nobody has rebuilt the services for Chat since that commit.

2 | LPS-42584 Update custom query & StatusFinderImpl in Chat portlet to support multiple social relation types

The pattern comes from method 'getFindByUsersGroups_SQL'.

3 | LPS-42584 Add new property...

You can see a pattern for including constants from a class in a properties file in the "portal.properties" for the property 'verify.frequency'. I didn't find a better way to list the available options.
I'm not sure in the name of the new property
I think, "social" sounds more general and expresses better the new functionality: social vs. site-based filtering
Descriptions are always tricky :)

4 | LPS-42584 Add new service method 'getSocialStatuses': I've found better to create a new method and keep the original one for backward compatibility

5 | LPS-42584 Apply changes to DefaultBuddyFinderImpl:

Is it necessary to keep the old conditions for "communities"? I don't think so, but I did not want to remove those without discussing it.

Please, review my changes & the LPS and let me know about your results.

Regards,
Tibor