Furyu/play-c3p0-plugin — pull request #1 by alexnauda (2013-11-29 17:13:36+00:00)
Title: Fix maxIdleTime and change to seconds for maxIdleTime, maxConnectionAge, and idleConnectionTestPeriod

Hello, and thank you for releasing this plugin. I've had problems with BoneCP and found that your plugin is working well for me after some tweaks. I have one bug fix and a suggestion to change three configuration parameters to match c3p0's configuration more closely:

Fix: Setting maxIdleTime was incorrectly setting acquireRetryDelay.

Suggestion: I was confused by this plugin's settings for...
* maxIdleTime
* maxConnectionAge
* idleConnectionTestPeriod
...because while c3p0 itself accepts these values as seconds, this plugin requires that they be configured as milliseconds. Please change them to match c3p0's settings so that it's easier to use the c3p0 documentation to configure these.