fisharebest/webtrees — pull request #43 by ddrury (2013-11-27 19:32:55+00:00)
Title: Combine gedcom_news & user_blog modules

Hi Greg,

When I was looking at fixing the CKEditor problem with editnews.php, I noticed a TODO in there about moving
its functions into the module

So I've done it. The gedcom_news & user_journal modules are both now incorporated in the blog module.

The add/edit form is now a modal dialog and whereas previously the user_journal module had a hard
coded option for deciding what happened if the contents overflowed the window (scroll bar), now both news &
journal have configurable options.

The downside is I've changed the configuration settings that are saved [class constants (integers) instead of
text strings], so if this module is adopted as a replacement either the user will have to redo his preferences
or a migration will be needed. New translations will also be needed.

I also incorporated the csrf stuff for saving or deleting articles and this raised a problem for the delete
function, previously the anchor had an onclick function that popped up a confirm dialog and if accepted just
called the delete routine. To incorporated the csrf stuff I had to create a modal dialog with a form (ugly!)
so that I could post the csrf token. Maybe a need here for a generic confirmation dialog?

Another thing I noticed was the addNews, deleteNews, getUserNews & getGedcomNews functions are in
authentication.php - shouldn't they be in functions_db.php?

The gedcom_news, user_journal & now the blog module call getNewsItem, getUserNews or getGedcomNews as
appropriate - it should be simple to convert these to one function - just tell it the type of id we're giving
it.

Phew, its taken longer writing this that do the coding!