jenkinsci/maven-plugin — pull request #12 by jwmach1 (2013-11-26 19:17:46+00:00)
Title: the perform method should be passing the loop-variable 'moduleBuild' to ...

From the junit-attachements plugin we see a contradiction between the
* hudson.tasks.junit.TestDataPublisher
* hudson.tasks.junit.TestResultAction.Data

The TestDataPublisher (without this change) is given a _MavenModuleSetBuild_. But when inside the hudson.tasks.junit.TestResultAction.Data.getTestAction(TestObject) calls hudson.tasks.test.TestObject.getOwner() it is given a _MavenBuild_.

When looking at this for loop in MavenTestDataPublisher it seemed natural to pass getTestData the moduleBuild. Otherwise the TestDataPublisher.getTestData is being called with the same MavenModuleSetBuild instance moduleLastBuilds.values().size() times.

The amount of testing I've done upon this change could only be described as anecdotal. Targeted unit tests may be required.