wmluke/angular-flash — pull request #21 by tony-kerz (2013-11-25 04:27:08+00:00)
Title: - directive: alter fade to remove activeClass to trigger browser fade, t...

...hen wait a few secs before cleaning up other flash classes to obtain a smooth fade

- altered demo css tp bump transition to 1s
- altered demo html to push 'alert' from 'activeClass' to regular 'class' attr

-------------

hi luke, i took a swag at a patch to smooth the fade out, which seemed to work, but unfortunately, it broke some tests because of the use of timeout.

i took a look, and tried a few things, but i wasn't able to figure out how to alter the tests to account for the async delay introduced by timeout. the use of jasmine.createSpy made my head spin ;o

i'd be happy to try again if you could provide some guidance, or if you know how to account for the timeout, i could learn from the master.

regards,
tony.