xbmc/xbmc — pull request #3691 by Montellese (2013-11-20 10:33:07+00:00)
Title: videodb: make sure to return the same playcount (0 or 1) for tvshows (fixes #14703)

This change makes sure that the playcount value of a tvshow retrieved from the database is always 0 or 1. Right now depending on how a tvshow is retrieved from the database (e.g. GetTvShowsNav or GetTvShowInfo) the m_playCount value of the CVideoInfoTag object can be either 0 or 1 or it can be the total number of watched episodes. This problem also results in inconsistent data being returned through JSON-RPC (see http://trac.xbmc.org/ticket/14703).

TBH I don't really care whether the playcount always is 0 or 1 or the total number of watched episodes as long as it is consistent. Are there any places that rely on playcount being one of the two possible implementations? I just went with the former (0 or 1) because it means less logic duplication (i.e. comparing the total number of episodes with the number of watched episodes).