puppetlabs/puppet — pull request #2095 by Iristyle (2013-11-20 19:03:36+00:00)
Title: (#15559) Windows security test fails under SYSTEM

- Previously get_mode spuriously included the S_ISYSTEM_MISSING bit when
the group or mode was SYSTEM
- Behavior has been adjusted in integration/type/file_spec.rb so that
when the current user is SYSTEM (like in a build server environment),
it's verified that there is at least one SYSTEM ACE that has FULL
access. When running under SYSTEM there may be many SYSTEM ACEs,
including inherited ones.
- In some cases, owner group or mode has been set to something that
can more legitimately setup our initial desired pre-test state. When
verifying that SYSTEM is granted FULL access, it's important that
SYSTEM not be assigned to the group or owner.
- Some tests have been marked pending where it's trickier to setup the
appropriate initial state when running the tests as SYSTEM. These
will be resolved when new security descriptor code is introduced.