jbosstools/jbosstools-server — pull request #176 by robstryker (2013-11-19 12:28:43+00:00)
Title: JBIDE-16025 do not attempt to change the state of as>7 or deploy-only server's deployment scanners during publish

The block of code inside RSEPublishMethod attempts to stop and restart the deployment scanners on the remote server. The current implementation is only fit for AS < 7. There does not currently exist an implementation (in our code) for AS>=7.

This block of code is entered, and attempts to ssh into the remote machine, and execute a twiddle command, to turn off (and restart) the scanners. It also delays for 3 seconds hoping that the change goes through.

This code is questionable already for AS < 7, but for AS >= 7, it is only a wasted 3-second delay with no purpose at all. Deploy-only servers also suffer from this delay, and deploy-only servers have no such scanners to even be turned off.

Since larger-scale refactors are not currently possible at this time, the best solution is to simply exit the block of code early if the target server is not < AS7.