diaspora/diaspora — pull request #4596 by jaywink (2013-11-17 21:47:27+00:00)
Title: Allow additional profile fields (previously private profile) to be set public

Change wording of profile sections to Basic and Additional. Add helper icons and rollover text to hint on visibility.

NOTE! Not ready for merge - some work to do on help pages and I haven't even looked at tests yet. Just here for initial review, whether this is even wanted (needed it myself).

See for example change running on my pod, my now public profile: https://iliketoast.net/u/jaywink

In the below screenshots, I realize now it's confusing that the globe and the padlock are not visible at the same time. The way it goes, you click the padlock in the Additional section and it turns into the globe, and if you click the globe, it turns to a padlock. The other two icons (globe for Basic data and padlock for Settings) are not clickable.

I didn't use a toggle slider as Flaburgan suggested since D* doesn't have any in use yet and I feel visual makeovers should be done in a separate stage.

Edit profile page - Basic (old Public Profile) and Additional (old Private Profile) sections visible, with additional set to public (the globe, by default it is limited = padlock, for new and existing profiles).

![pic](http://i.imgur.com/QEYfjGK.png)

The lower part, didn't have a title before and thus was confusingly mixed with Public Profile - now titled Profile Settings, with padlock to show it's not public data.

![pic](http://i.imgur.com/v4IwyRs.png)

Hint rollover in Additional section - wording is not very good at the moment..

![pic](http://i.imgur.com/PYm7MqY.png)