learning-unlimited/ESP-Website — pull request #807 by benjaminjkraft (2013-11-16 22:26:24+00:00)
Title: Various fixes to the schedules printing script.

This fixes several bugs with the schedule printing script, including the
one where it hosed the entire site. Fixes:

1. The printing script would refresh even if the previous response had
not loaded. If the previous response took longer than 2s to load, this
would build up requests on the server and make it sad. Now it will
wait.

2. The LaTeX renderer was breaking on PNG output if the document was
more than one page. Now it will return the first page; I think this is
the most reasonable thing to do. It's certainly what makes sense here
(since the second page is probably just a barcode), and I think this is
really the only place PNG output is used anyway. If we ever have
multiple pages of content in the schedule, this script will have to be
rewritten, as it relies on rendering to PNG.

3. The "print schedules" button on the onsite grid was submitting with
the printer in the URL, rather than as a GET parameter. This was
because the other view that does a similar thing wanted it in the URL.
Now they are consistent (as a GET parameter) and are called correctly by
their respective frontends.

4. The view that adds a PrintRequest was erroring because it was trying
to set the printer as a string, where it should be a Printer object.
This has been fixed.