OpenELEC/OpenELEC.tv — pull request #2756 by jmbreuer (2013-11-13 09:08:39+00:00)
Title: Enable auto-repeat for all non-qualifier keys

For a while now, I'm running OpenELEC 3.2 with XBMC master from git (due to local fixes).

In this constellation, auto-repeat for the volume keys on my Nyxboard Hybrid remote stopped working, AFAICR around April/May this year.

The Nyxboard Hybrid attaches as a USB HID keyboard.

I've tracked this down in the code; XBMC requires keyboard repeat events generated by SDL to react to keys being held down.

Repeat events are generated by SDL only for "known" keys (an arbitrary list of scancodes) that are not qualifiers.

Since the multimedia volume keys are not "known" by SDL 1.2.15, no repeat events are generated.

This patch causes SDL to repeat *any* keys except known qualifiers; i.e. there should be no difference in behaviour across all non-qualifier keys on a keyboard with this applied.
This IMO is the behaviour most suitable in an OpenELEC/XBMC environment; the user would not wish some (unknowable) keys to behave any differently from others.

With this patch applied, the Nyxboard volume keys repeat when held down, as before whatever caused this to stop working.

I'd be interested in any folks using (logical) keyboards for control whether it causes any problems.