geyslan/metasploit-framework — pull request #1 by todb-r7 (2013-11-11 16:43:56+00:00)
Title: Fixes for #2350, random bind shellcode

* Moved shortlink to a reference.
* Reformat e-mail address.
* Fixed whitespace
* Use multiline quote per most other module descriptions

Still need to resplat the modules, but it's no big thang to do that
after landing. Also, References do not seem to appear for post modules
in the normal msfconsole. This is a bug in the UI, not for these modules
-- many payloads would benefit from being explicit on their references,
so may as well start with these.

I'll be testing these payloads today because they're neat and small, according to info:

````
msf > use payload/linux/x86/shell_bind_tcp_random_port
msf payload(shell_bind_tcp_random_port) > info

Name: Linux Command Shell, Bind TCP Random Port Inline
Module: payload/linux/x86/shell_bind_tcp_random_port
Platform: Linux
Arch: x86
Needs Admin: No
Total size: 179
Rank: Normal

Provided by:
Geyslan G. Bem

Description:
Listen for a connection in a random port and spawn a command shell.
Use nmap to discover the open port: 'nmap -sS target -p-'.

msf payload(shell_bind_tcp_random_port) > use payload/linux/x64/shell_bind_tcp_random_port
msf payload(shell_bind_tcp_random_port) > info

Name: Linux Command Shell, Bind TCP Random Port Inline
Module: payload/linux/x64/shell_bind_tcp_random_port
Platform: Linux
Arch: x86_64
Needs Admin: No
Total size: 226
Rank: Normal

Provided by:
Geyslan G. Bem

Description:
Listen for a connection in a random port and spawn a command shell.
Use nmap to discover the open port: 'nmap -sS target -p-'.

msf payload(shell_bind_tcp_random_port) >
````

See that the x86 random bind is 179 bytes, where the regular tcp bind is 200, and similar savings on the x64 versions.

Anyway, no need to threaten a punitive license change to GPL, just a ping to revive review on this is plenty!

Please take a look at these fixes to rapid7/metasploit-framework#2350 to just make sure I didn't screw anything up. Also, if you'd like to add source for the x64 payload, it looks like you'd be the first in x64 Linux land (we only appear to ship source for 32-bit payloads for linux, so far).

BTW, I see your source branch is your `master` branch. This is almost certain to cause problems for you down the road when you try to resync. See https://github.com/rapid7/metasploit-framework/wiki/Setting-Up-a-Metasploit-Development-Environment#wiki-sync for more, and good luck.