orocos-toolchain/rtt_ros_integration — pull request #2 by meyerj (2013-11-08 09:05:32+00:00)
Title: Some enhancements for rtt_ros_integration

Copied from http://bugs.orocos.org/show_bug.cgi?id=1000:

I think the issues are still valid and I also would like to send a similar pull request to @jbohren's hydro-devel branch for the case they are accepted for master.

> Johannes Meyer 2012-10-24 17:14:06 CEST
> Created attachment 833 [details]
> fixed segfault when creating streams for ports without a DataFlowInterface

> I would like to contribute three patches for rtt_rosnode which basically enable generation of RTT typekits in other packages without a having to add a separate package. As bugzilla only allows to add one patch, I will add them as additional comments.

> 1. The first patch is more a bugfix as an enhancement, as the current version will segfault if used with ports that are not part of a TaskContext or DataFlowInterface, only because of logging port names.

> Comment 1 Johannes Meyer 2012-10-24 17:16:16 CEST
> Created attachment 834 [details]
> moved implementation of ros_publish_activity from header to source

> This patches moves the implementation of the RosPublishActivity from the header to the source file. This allows including the header in other projects, e.g. to modify the priority of the publish activity.

(It also saves a few bytes in the transport libraries).

> Comment 2 Johannes Meyer 2012-10-24 17:19:07 CEST
> Created attachment 835 [details]
> moved set and add_definitions commands to ros_generate_rtt_typekit

> The GenerateRTTtypekit.cmake file modifies some cmake variables which are then valid for all subsequent targets added within the same project. Moving them to the ros_generate_rtt_typekit function does not change anything for typekits but does not affect other targets.