simonc/ariane — pull request #13 by durrantm (2013-11-05 22:00:03+00:00)
Title: rspec expect() syntax, plus using 'match()' over '=~' and 'eq' over '=='

Hi, I'd like to offer this suggestion for changes to the RSpec syntax to use expect. More than just a style change, it has turned turned out that using 'expect' over 'should' is a recommended practice because of dealing with delegate/proxy objects as detailed in http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
As detailed in the blog post "In the future, we plan to change the defaults so that only expect is available unless you explicitly enable should. We may do this as soon as RSpec 3.0, but we want to give users plenty of time to get acquianted with it." I've also noticed that many of the major github gems have already made the move.
I changed the pattern matchers from =~ to match() as required for this change and while at it I also took the opportunity to change the '==' operator to 'eq' as recommended in the post.
I also uncommented a test in spec/ariane_spec.rb and got it to pass, so I'm leaving a higher coverage than I entered :)
All tests pass.