nephila/aldryn-installer — pull request #33 by henning (2013-11-03 22:07:00+00:00)
Title: remove unexecuted test asserts

These assertions are never actiually executed, as the with used with the assertRaises simply doesn't work that way.
The block only get's executed until the config parsing where the intended exception occurs.

I thought about how to actually implement the intended tests for the right error message, but didn't come up with a proper and simple solution.

Therefor I rethought, and came to the conclusion/opinion, that it's unlikely that the config.parse() method will error out with a different exception in that situation, and it's no big loss when this detail is gone.
While totally agreeing that the more detailed checks, the better, in this case I think the tests are good enough even without the more exact checks (prove is, these checks are written, but never ever excuted, and obviously that didn't result in mayor problems yet).