jprante/elasticsearch-river-jdbc — pull request #125 by mwing (2013-10-31 06:48:50+00:00)
Title: Not closing the Statement leaks cursors with Oracle in executeQuery(String) method

I noticed a problem when implementing our own strategy using Oracle. The symptom was an SQLException with message ORA-01000: maximum open cursors exceeded. A little debugging lead me to the executeQuery(String) method which apparently leaves the Statement open even after the ResultSet is closed.

Looking through the code it seemed that using the executeQuery(PreparedStatement) method does exactly the same as the now unused executeQuery(String) method did except for using a different Statement. I removed the (String)-method with the comment about PostgreSQL as the fetchsize was set in both methods.