Harvard-ATG/HarmonyLab — pull request #15 by arthurian (2013-10-30 02:05:18+00:00)
Title: feature/fix-root-highlight

This pull request addresses an issue with the "root highlight" mode. The issue is that when there is more than one instance of a root in a chord, none of the instances are highlighted. The expected behavior is that *at least one* of the roots should be highlighted. Currently, root highlighting only works when there is one instance of the root. This PR fixes that.

There are three possible ways to address the issue and all of them were considered:

- Highlight the "highest" root in the chord.
- Highlight the "lowest" root in the chord.
- Highlight *all* roots in the chord.

This PR implement the last option, highlight all roots, because (a) there is no consensus about which way is the best and (b) this approach is most likely to elicit feedback from learners about whether it is helpful or not.