CleverRaven/Cataclysm-DDA — pull request #3941 by ianestrachan (2013-10-29 03:46:43+00:00)
Title: Fix NPCs not giving you the things they said they were giving you.

> Player: Well, I am helping you out...
"Joe Schmoe gives you an antibiotics"
Player: (receives lighter)

No more! While I'm not 100% sure *why* this works (aside from the lingering suspicion that pointers are a tool of the devil), I tested it and emptied an NPC's inventory of items that all were exactly what they said they were.

If I absolutely had to guess, I'd say that some weirdness was happening due to fiddling with the item while it was still in the NPC's inventory, and then removing it afterward, when its state might possibly have changed? Now it removes the item as soon as it can and THEN fiddles with it, protecting it from any such nonsense.

Either way, NPCs gifts will work again.