mozilla/socorro — pull request #1624 by twobraids (2013-10-28 22:06:25+00:00)
Title: Fixes Bug 930310, Bug 908798  Added 'unredacted' to the crash_data service - and a snowball of other issues

this PR represents adding the 'unredacted' service to the crash_data service. Because this work was intimately involved in the working with both the hb and fs classes, I've taken the liberty of moving the middleware to use those classes by default instead of the old hbase and filesytem classes.

Since the services for each of fs, hb, filesytem, hbase were nearly identical except for the instantiation of the crash storage instance, I've consolidated the code into one file .../socorro/middleware/crash_data.py.

The crash data service for filesystem hard coded the dependency on the postgres priority job service. The hbase crash data did the same thing except for employing the rabbitmq priority service instead. I've rectified this and made them all search for the configured Priorityjob service. This necessitated adding the 'all_services' key to the Implementation wrapper in the middleware_app.py.

Testing was a disaster. I don't seem to have an environment in which I can actually run the integration tests. therefore, I've submitted this PR in the hopes that it'll test in jenkins and I can catch and fix the errors there.