lonelyplanet/ui-test — pull request #16 by musocrat (2013-10-24 22:08:21+00:00)
Title: Andrew Carpenter LP UI Test

Okay, so I've done a few things here. Structured SASS into SMACSS style structure, created modules for js (read-more, lightbox, and nav). On js, I would typically be combining the files on the output (rather I'd let Asset Pipeline do that), but Guard doesn't do that and i chose not to introduce another gem for it.

On the HAML I refactored the index around json structure. In a production environment I would leave this to models -> ActiveRecord. Started down that path, but for this test it would be more trouble to evaluate if I introduced models, db, etc... Also did some refactoring of the footer nav. I didn't really mess with the structure of the HAML files. I would typically structure them a bit more modular with partials and such, but because of the minimal content i chose not to do that and rather focus on the CSS/JS/styling more.

The SASS was refactored around dry principles using placeholders and removing unnecessary properties as I came across them.

The JS was refactored into a couple simple functions each. If I had more time to spend on js I would focus on testability. JS testing is something that I've not worked in before aside from code conformance testing via Jslint / Grunt / Travis-CI. I am going to start building test for [jQuery Video Lightning](https://github.com/musocrat/jquery-video-lightning) to get more familiar with building testable JS.

On the styling / UI I mostly followed the design of the current production site. There are some variances like the thumbnailed images to the left of the content rather than the image slider as well as the footer nav.

Thank you for giving me something fun to work on today, I enjoyed it.