adobe/brackets — pull request #5674 by njx (2013-10-24 20:54:13+00:00)
Title: Remove check for subtree modification, since it can fire erroneously when $.find() is called

This fixes a failure in InstallExtensionDialog-test. The failure was introduced in a0f4b15, but it wasn't really a bug in that commit. The problem is that the unit test was using a DOM mutation event handler to try to ensure that the UI of the dialog didn't change if the user hit Enter while an install was occurring. a0f4b15 happened to add an extra call to `$.find()` with a complex selector, and it turns out that jQuery temporarily modifies the DOM when querying for a complex selector within a given element (adding an ID to the element being queried). This doesn't happen for simple ID/class/tag selectors.

We could modify the test to actually diff the subtree to ensure that it's the same before and after, but in this case it seems good enough to just test that neither of the installer's methods get called (which it was already doing). So I just removed the mutation check.