opentable/puppet-teamcity — pull request #2 by bcatlin (2013-10-24 23:35:37+00:00)
Title: home directory wasn't being set right, this fixes it

I believe this error was caused by this issue: http://teamcity/viewLog.html?buildId=424525&buildTypeId=bt2186&tab=buildLog#_focus=3387

According to the reference "The directory must be created separately and is not currently checked for existence." (see http://docs.puppetlabs.com/references/latest/type.html#user-attribute-home)

I think the way the current code was running it was creating the home directory, then group, then user. This means the permissions can't be set right on the home directory.

Tested in isolation, this works.