rebar/rebar — pull request #157 by Vagabond (2013-10-17 00:01:41+00:00)
Title: Don't over-aggressively clean the code path in the presence of lib_dir directives

Rebar, when it encounters a lib_dir directive, caches the current code
path, adds the libdir(s) and returns the cached copy of the path. When
rebar has finished processing that directory, it restores the cached
path. This is problematic in the below scenario:

```
/(lib_dir)->G
A -> B -> C -> D -> E
\-> F -> D -> E
```

When rebar is finished processing B, it restores the code path to what
it was before it processed B, removing C, D, E and G from the code path.
This means when it comes to process F, neither D or E are in the code
path, so any header includes, rebar plugins or parse transforms will not
be in the code path. Without the lib_dir directive, rebar does no code
path cleanups, so everything works fine.

This change makes rebar only remove the explicit lib_dir code paths it
added and adds an inttest that replicates the above scenario.

I don't actually know why rebar feels the need to do this in the first place, but this code has been in rebar since 2009, pretty much unchanged:

https://github.com/rebar/rebar/commit/3990f0a0766e5e508e319e73139df93cc4c3bde4

This patch still ensures the lib_dirs are stripped when exiting the directory, but if the lib_dirs contain applications with deps those will not be removed from the code path. I don't know if this is good or bad.