discourse/discourse — pull request #1533 by velesin (2013-10-16 15:59:16+00:00)
Title: removes unused return statement from ContainerView.attachViewWithArgs

There are two similar methods in Discourse.ContainerView: attachViewWithArgs and attachViewClass. First one (attachViewWithArgs) returns newly created view while the second one (attachViewClass) does not return anything. This is asymmetrical and should be unified, so either both methods return newly attached view or both methods return nothing.

I have checked all the places where attachViewWithArgsis is used, and the value returned from this method is never used (never assigned to anything), so I've chosen the simpler variant - both methods return nothing.