lonelyplanet/ui-test — pull request #12 by justinthrelkeld (2013-10-15 03:28:30+00:00)
Title: Justin Threlkeld's pull request

First, I decided to modularize as much stuff into separate files as possible. With the assumption of working within a large team, having multiple files will help prevent version control hell and anguish.

Next, I standardized element and function names into a simple BEM-inspired taxnonomy. At this point, I also moved to more semantic names and element usage.

From there, I abstracted the functionality of various functions and style rules to allow them to scale with relative ease.

In the refactoring, I also made two improvements: added in Bourbon & Neat for cross-browser styling support and the beginnings of a responsive layout, and added a "fancy images" JavaScript module that uses the advanced image sizing rules of css background images for images wrapped in `.image` classes.

I also removed the animation functionality from the `read-more` module, opting for the scalability of toggling between a defined `height` of `400px` and a `height` of `auto` via css classes. Unfortunately, css transitions won't work in this situation, but with a simple JavaScript addition, we could add the animation functionality back.

For further improvement, I would continue down the responsive path and restructure the DOM to put navigation below the content. I would also build animations and transitions into the interface and utilize some type of smooth-scroll.

See this responsive template [on GitHub](https://github.com/justinthrelkeld/oncanvas-template-middleman) for an idea of how I would accomplish the layout.