shinnlok/liferay-portal — pull request #55 by jonathanmccann (2013-10-07 21:29:02+00:00)
Title: LPS-40923

Hey Shinn,

For this one, I included the articleId for all of the exceptions that are being thrown that did not have any message attached to them. I changed the validate functions to send/receive the articleId parameter so that this would be possible. In some cases, when a user is adding a brand new article, the article ID may be null (if the client has autogeneration of articleIds set to true) and in that case the exception will be:

com.liferay.portlet.journal.ArticleTitleException:

instead of the normal:

com.liferay.portlet.journal.ArticleTitleException

However, I don't see that being too large of an issue because usually when a user is adding a new article, the exception is handled by the GUI and a stack trace isn't generated. I could move the autogeneration of the articleId before the validation, but this is done no where else in the portal and then it would display an articleId that does not actually exist and provides no extra information to the user. I could have also sometimes used the title and sometimes used the article ID but the title validation happens partway through so it would be a lot of if statements for these logs to determine to output the title, articleId, or nothing.

If you have any questions or concerns just let me know.