scanny/python-pptx — pull request #48 by hoopes (2013-10-07 11:40:12+00:00)
Title: Wordwrap attempt #2

Hi,

This is my second ever pull request, and first github contribution, so I welcome any criticism or guidance. Ha. Accd to stackoverflow, the only way to change a pull request was through the REST api, or just create a new one. Creating a new one seemed quicker.

I hope this is the correct procedure now. I obviously have more to learn about git (I'm a mercurial man so far...). Plus the thing on the right says the branches can be auto-merged, so that's gotta be good....

I wanted the textbox that I created to keep the width that I set, and to do so, apparently I needed wordwrap to be enabled. It looked like I needed to remove the wrap="none" from the xml.

I added a test, but it appeared to be the only time actual text is put in the xml (other than name, id, h/w, etc). If there's a preference on how you'd like this done, please let me know. I also made the new param optional, so there's hopefully no backward breakage.

In any case, thanks very much for the library, and I hope you keep working on it!