opensourcery/turnip — pull request #24 by adamdicarlo (2013-10-04 21:50:24+00:00)
Title: Sparkify Turnip

Not yet ready for merge, but here's my work so far on CKEditor 4 + Spark integration.

Some findings:

* Use CKEditor 4.1 specifically
* Use jQuery Update 2.3 as newer commits have upgraded jQuery UI, which for some reason breaks create.js (this is why Spark for D7 is now broken -- its makefile uses jquery_update "2.x-dev")
* Set jQuery Update to use jQuery 1.7
* Ember (admin theme) 2.x looks awesome *except* it's completely unusable for the "select file display mode" stage of inserting media, so we can't use Ember yet :frowning:
* Picture module seems to screw up image file display (and makes saving the file display form impossible) if you don't have any groups defined
* CKEditor [Media 2.x integration patch](https://drupal.org/node/1504696) is pretty decent but:
* You need to turn off CKEditor's Advanced Content Filter to avoid mangling Media plugin's short codes
* Media button doesn't work for edit in place (maybe the media ckeditor plugin JS doesn't get loaded?)
* Adding attributes to an image placed via Media plugin (which uses [[{...}]] format) doesn't store them anywhere, so they get immediately lost
* Maybe adding float-left and float-right to CKEditor styles will work with images? That's my hope.