cooperative-computing-lab/cctools — pull request #222 by dthain (2013-10-03 14:21:19+00:00)
Title: Fix name of remotely cached files.

This is a small pull request but requires some discussion. @btovar @dpandiar @malbrec2

First, I have factored the (repeated) generation of the remote cached name into make_cached_name() so it is defined in a single place. Currently, a file is stored in the cache directory according to its remote name.

Second, there is a hash table that records what files are currently stored in the cache directory. Currently, the hash table records each file under the hash key "remotename-localname". I am fairly certain this is incorrect -- if the master wants to keep track of the contents of the directory, it should do that using exactly the names under which the file is stored.

So, this pull cleans up the handling of the hash table by using exactly the cached file name as the key for the worker->current files hash table.

The question as to *what* name to use in the cache directory is a separate issue -- I am simply going for internal consistency at this point.

Does this look right?