russss/Herd — pull request #5 by chalupaul (2013-10-02 17:45:51+00:00)
Title: Made a few improvements, hope you like them!

We've been using this in prod for about a month or two now, and wanted to add these features based on our ops team's feedback.

Added argparse options instead of raw sys argv.

Fixed a regex bug where it wasn't accurately snagging comments.

Added in a retry option in case murder fails because of a time out or other problem.

Added in a log directory so you can see what failures are happening within the ssh session (not really applicable for scp, so I didn't put it in there).

Additionally, patched murder_client to return 1 in case of failure or error so that it can be handled upstream (It was returning success in all situations). This could theoretically be extended to provide more intelligent return codes, but just 0 or 1 :: "Success" or "Failure" should suffice for most cases.

Finally, failures on particular nodes will be displayed on the screen instead of suppressed so you can take appropriate actions.