bmabey/database_cleaner — pull request #248 by rhunter (2013-10-02 05:45:22+00:00)
Title: Sequel specs

It looks like DatabaseCleaner's code paths for Sequel [aren't tested as much]pendingspec] as the more popular ActiveRecord code paths.

I'm relatively familiar with Sequel and various kinds of automated testing. I'm new to the DatabaseCleaner codebase, though, so I'm trying to keep in line with the existing tests. I'm also avoiding making any changes to the code under test (for now).

I'd appreciate feedback, particularly on the following topics:

* integration testing (does it work when we run it for real?) vs implementation testing (do these methods get called?)
* modules and namespaces
* ruby 1.8 compatibility
* allowing one-shot `Truncation.new(db: foo)` instead of `t = Truncation.new; t.db = foo`

This pull request probably isn't done yet (although if you want to merge it, it can't hurt).

[pendingspec]: https://github.com/bmabey/database_cleaner/blob/v1.1.1/spec/database_cleaner/sequel/base_spec.rb#L27