rackerlabs/repose — pull request #712 by dmnjohns (2013-09-23 17:05:07+00:00)
Title: D-14567 Damage DD and Local DD Taking Over

@malconis @rackerwilliams

I'm uncertain about catching the DatastoreOperationException here. From what I can tell, it isn't currently used for anything at higher levels of the call stack, but considering that we had left it for the rate limiting handler to catch prior to this, I wonder whether catching that exception is one of the datastore's responsibilities.

I've also considered having the isRemoteTarget(...) method of this class throw a RemoteConnectionException when catching a SocketException rather than a DatastoreOperationException. I'm not confident enough in my understanding to make that call right now, though.

The proposed changes seemed to be the most sure-fire way to fix the defect with minimal code change.