nasa/mct — pull request #196 by VWoeltjen (2013-09-24 00:07:26+00:00)
Title: [Views] Restore prior form of hashCode/equals for ViewInfo

This restores prior logic for hashCode and equals in ViewInfo, upon which the filtering of redundant views from the view menu is contingent. This addresses nasa/mct#195

Additionally, amended unit tests to match this change and add comments detailing the rationale to reduce the change of repeating this regression.

Wrote or re-wrote unit tests (Y/N): Y
Ran entire suite of unit tests successfully (Y/N): Y
Verified bug fix with the described replication steps or verified the implementation meets the requirement cited (Y/N): Y
Code coverage requirements satisfied (new code=80%, changed code=at least as high as existing) (Y/N): Y
Code review date and attendees: Code review by pull request
Describe potential impact on other areas of the code: Views, view comparisons
Describe any test prerequisites for this fix (e.g., restart the database): N/A
For bugs marked "Regression - Yes", describe the cause of the regression: See below
Did you modify any pom.xml file? If yes, did you thoroughly document your changes and reasons? N

Regression was introduced in 8a4faa9f7a1ca763712084e76fd39ac49b22ff56 as part of pull request #184 addressing issue #145. In amending unit tests (for coverage and to ensure up-to-date) the definitions of these methods (hashCode and equals) were redefined to include view type, in order to provide specificity (this appeared to be a fault in existing code). However, view type appears to have been omitted intentionally, as the View menu in MCT relies on its omission in order to filter out redundant views.