scala/scala — pull request #2942 by retronym (2013-09-13 08:48:59+00:00)
Title: Remove build.number.maven

I can't find any justification for having this information
in both build.number and build.number.maven.

They have drifted apart on the 2.10.x branch, although that
doesn't matter because build.number is correct, and loaded first,
and Ant properties are write-once.

I'm assuming that the Ant tasks in src/build/pack.xml are only
invoked through the -s in ./build.xml.

Here's a test of that from the 2.10.x branch:

% cat build.number
#Tue Sep 11 19:21:09 CEST 2007
version.major=2
version.minor=10
version.patch=3
# This is the -N part of a version. if it's 0, it's dropped from maven versions.
version.bnum=0

# Note: To build a release run ant with -Dbuild.release=true
# To build an RC, run ant with -Dmaven.version.suffix=-RCN

% cat build.number.maven
version.major=2
version.minor=10
version.patch=0

% git diff
diff --git a/build.xml b/build.xml
index 3a83aa4..5cb952c 100644
--- a/build.xml
+++ b/build.xml
@@ -62,6 +62,9 @@ TODO:

+

+
+
+
+

% ant distpack.maven.info
Buildfile: /Users/jason/code/scala2/build.xml

distpack.maven.info:

pack-maven.info:
[echo] version.patch = 3

Notice how the stale `version.patch=0` in build.number.maven is
ignored.

Review by @lrytz @jsuereth @gkossakowski