cms-sw/cmssw — pull request #827 by Dr15Jones (2013-09-13 19:21:02+00:00)
Title: Update MessageLogger to use new thread-safe Service signals

As part of the migration path to updating the MessageLogger to use thread-safe Service signals, the code also got a major 'spring cleaning'. Turns out the old CDF messaging system was embedded into the CMS MessageLogger but only a tiny fraction of it was used. The unused code was refactored out of the system.

NOTE: Even though this change does use the new Service signals it turns out that for a fully task based system the MessageLogger could use the incorrect context when reporting a message. This would happen if
1) A task which issued a service signal (say entering a module) does a TBB wait (e.g. because of a tbb::concurrent_foreach).
2) The system starts a new temporary task where that task also sends a service signal (say 'preEvent').
3) When the second task finishes, tbb goes back to the original task, however the MessageLogger would still think we are in the original task since no further service signals have been issued.
It seems likely that the Service system will have to issue a 'returnToTask(...)' call in these cases and therefore have to track what was the previous task on this thread. However, that will not be needed until phase 2.