Zizaco/confide — pull request #151 by serphacker (2013-09-13 13:30:11+00:00)
Title: Bruteforce throttling vulnerability

Using HTTP_X_FORWARDED_FOR in the key is useless because the client can set a random X-Forwarded-For and bypass throttling.
Secondly using email in the key is useless too because there is little chance the same IP needs to access multiples accounts and have lost its passwords for all its accounts.

The rare case when one IP need to access multiple accounts is when it's behind a reverse proxy. In this case the 'HTTP_X_FORWARDED_FOR' should be used if it's properly set by the reverse proxy and not overridable.

Most of the time web application aren't behind reverse proxy so it's safe to only check REMOTE_ADDR