tgstation/-tg-station — pull request #1357 by AndroidSFV (2013-09-13 04:58:09+00:00)
Title: A iphotography

Gives the AI two verbs, Take Picture and View Picture. The AI can also print these pictures at a photocopier if there is enough toner, and on a newscaster. The AI is given an ai_camera in New(). The picture is taken centered on the AI's eyeobj. I broke up some of the original photography code so that it could be used with the AI camera.

Added some checks to photocopier.dm that when the AI tried to eject a photo from a photocopier, it would end up in the AI's hand. Also increased the amount of toner a photocopier holds (and how much a toner cartridge adds) to 40.

Consolidated some datacore code into datacore.dm.

To come in future pulls: A way for AI's to delete pictures they don't like so it isn't cluttered, targeting of the center of the picture, giving this functionality to borgs, unifying picture storage/viewing among all silicons, making the selection interface into some form a window with html interaction.

Please offer any feedback or criticism in a detailed manner so I can address it properly.

Notes: code/datums/obj.dm and /code/defines/obj.dm, where I found those bits of datacore code, do not really serve a purpose and should have their contents shifted into more appropriate .dm's. Also, when you try to take a picture of the kitchen, the kitchen turfs appear black in the picture. I will open issues for both.