rjbs/Dist-Zilla — pull request #210 by dolmen (2013-09-07 23:45:07+00:00)
Title: Use dependencies unconditionally in generated release tests

This is about release tests generated by `MetaTests`, `PodSyntaxTests` and `PodCoverageTests`.

TLDR: read the short patches ;)

In previous commits (32c49608cbe76712545d82b9d6a33791f8b41466, 5efbc7fa25591d82ebe7d8c13606cff8754d9f06, 0e64da3e72cc5cc0213242eeea4d2d3b46e348ee) we have added dependency injection to those plugins to ensure that the developer has all the dependencies of those tests installed if he has installed everything from `dzil listdeps --author`.
But the code of the generated tests still implements conditional loading of those dependencies, and skips the test if the dependency is missing. This isn't just unnecessary anymore: this is simply wrong. Because those tests are release tests. We want those tests to do their job. Silently skipping a release test just because a dependency is missing will not help the developer to reach his quality goal. Instead a test failure if the dependency is missing is the proper behaviour.

So this patch serie removes the conditional loading.
If for an obscure reason the dependency can't be loaded, the test will fail and the developer will be aware of the issue.

Less code and a better behaviour. Win/Win :)