jbosstools/jbosstools-server — pull request #144 by robstryker (2013-09-05 14:21:14+00:00)
Title: JBIDE-15392

This patch performs the following:

1) Moves 4 classes from o.j.i.e.as.classpath.core.runtimes to o.j.i.e.as.classpath.core.runtimes.internal
2) Moves Messages and Messages.proprties to o.j.i.e.as.classpath.core.internal
3) Removes 2 methods in ClasspathCorePlugin which expose internal classes in official api (API LEAK)
4) Moves most of CustomRuntimeClasspathModel's methods into an internal class as implementation details.
5) Moves CustomRuntimeClasspathModel.IDefaultPathProvider interface into its own class IRuntimetPathProvider
6) Moves internal class CustomRuntimeClasspathModel.PathProviderFileset to RuntimePathProviderFileset
7) adds methods to RuntimePathPRoviderFileset to allow for resolution without an IRuntime
8) Adds test case for all changes.

This counts as several large API changes, though there are NO clients outside of jbosstools-server repository. Moving Messages class counts as an API change. Moving the 4 classes mentioned in step 1) count as API changes. Removing the 2 api-leak methods in step 3) count as api change. Step 4) counts as API change (many public methods (whch should never have been public) were moved. Step 5) is API change. Moving inner-class interfaces and impls' are API change.

So, it's a lot of API changes, but with almost no consumers. However, the added test case shows that we can now retrieve a set of jars either an IRuntime or a server home location separate from an IRuntime. So, this is very good.