opscode-cookbooks/haproxy — pull request #38 by rberger (2013-09-04 00:43:34+00:00)
Title: haproxy_defaults_options method tries to update Chef::Node::ImmutableArray if node['haproxy']['x_forwarded_for'] is set

Looks like if node['haproxy']['x_forwarded_for'] is set, an operation is applied to it that is illegal now that the node['haproxy']['x_forwarded_for'] attribute is a Chef::Node::ImmutableArray. This fix changes an assignment:

```
options = node['haproxy']['defaults_options']
```
to
```
options = node['haproxy']['defaults_options'].dup
```

(dup's the node['haproxy']['defaults_options'] into a normal array which can then be properly used as in:

```
options.push("forwardfor")
```

I could not see anyplace in the code where it expected node['haproxy']['x_forwarded_for'] to be actullly updated by this method, just that the result of the method has the merge of node['haproxy']['x_forwarded_for'] with