basho/riak_core — pull request #365 by rzezeski (2013-08-30 19:20:59+00:00)
Title: FIx set_bucket (don't leak "my ring" into "raw ring")

While writing a test for migration from Riak Search to Yokozuna I noticed that after setting the bucket property `search` to false the Riak Search pre-commit hook property was being store in the **raw ring**. This should **never** happen as that bucket prop is written to the "tainted wring" (also called "my ring") by the bucket fixup process.

I noticed this issues on 1.4 which also has changes to how bucket properties are stored. I'm not sure this can actually happen on 1.3. BUT, even so a ring transition should **NEVER** use anything but the `Ring` passed into the transition function so this fix applies no matter what. I.e. it can only help and not hurt.

This fix should also be applied to 1.4 and the latest development, but this will act as the canonical PR.