brianbianco/redisio — pull request #83 by dennybaa (2013-08-30 09:09:26+00:00)
Title: Upstream

Hi,

I've fixed a few things regarding upstart.

---------------------------------------------------
Also I'd like to share about your cookbook if you don't mind. I've being trying to customize the cookbook ohh. it's not easy the concept you've chosen putting all the code into RedisioInstall provider is doubtful (though I haven't looked into you 2.0 branch). The configuration files for redis and every piece is hold in the attributes that is perfect! But hard-coding the installation and the configuration of services putting them into the provider and moreover into a separate resource collection - it's bad(

Since I was going to use my prebuild package from a repository but it wasn't simple. The way you arranged that all can't make your cookbook a good "library" cookbook. Finally I monkey-patched you RedisioInstall provider to skip download, install I was going to use just the configure, but since it has errors in upstart template I couldn't influence on it (like rewinding the template resource). Sorry for this piece of criticism, anyway you have done a great job thank you, Brain. Just wanted to share maybe it can be helpful for the development of the next cookbook versions.

Best,
Denis