puppetlabs/puppet — pull request #1854 by scenek (2013-08-27 13:25:47+00:00)
Title: (#14458) Fail when cannot apply complete catalog

Under some circumstances (eg. dependency cycle) when catalog could not be
applied, Puppet didn't report failure (status unchanged, return code 0).

Raise Puppet::Error so the failure gets logged and reported (status is
"failed", return value is 1).