juliocamarero/liferay-portal — pull request #2364 by matethurzo (2013-08-26 08:08:36+00:00)
Title: LPS-39241

Hey Julio,

This is a bug fix regarding portlets are not showing up on the publish UI.

The original problem I discovered was that if a portlet is staged like bookmarks it does not show up on the publish UI when I'm selecting the applications. I've realized the code doing this part is explicitly excluding the portlets with default preferences. Now on the UI there are two parts: to publish all applications or I can select which ones I want to publish. If I select all applications then the bookmarks (with the default setup) will be published then it makes sense to have it in the list where I can select the applications.

There is an other aspect of the change as well. Now with this change portlets like sign in do show up in the list where I can select the applications. This is intentional.
When we are talking about staged portlets we are commonly mean "their content is staged" but in fact the setup is always staged. So as we have separated the content and setup sections on the UI the portlets like Sign In has a place in the application section.
Also when we are selecting all applications they are being published as well, so it makes sense to have them listed.

I've added some test cases as well to test out my changes.

Thanks,

Máté