CampFireManager/cfm2 — pull request #177 by JonTheNiceGuy (2013-08-25 21:36:29+00:00)
Title: Fixing issues raised after merging #175

PullRequest #175 introduced some issues in the Puppet manifest, and
introduced issues in the unit tests. This commit fixes many of those
issues (plus issues which were identified as a result).

* Puppet now also installs Gammu-smsd and Gammu-doc. It points the CFM2
install file to the MySQL definition for Gammu, to install that as well
(Puppet).
* GenericObject now checks for the "old" value before simply inserting
it (Unit Test). To prevent PDO locks with multiple SQL statements, it
also closes cursors where required (Install script). Lastly, it checks
when installing database tables that the changelog table already exists
before proceeding (Install script).
* Object_Userauth checks whether "old" values are set before referring
to them (Install script).
* Install script now only freshens the jQueryMobile libraries, not
prompts (Install script)
* Amended talk tests in the Limbo plugin to return the correct slot
based on current logic (Unit Test)
* Ensure that the sessions are saved to an appropriate place during unit
testing (/tmp) - (Unit Test)
* Prevent testing of OpenID from erroring due to headers already being
sent messages (Unit Test, but probably not a bad idea elsewhere too?)