ADOdb/ADOdb — pull request #3 by knbknb (2013-08-23 10:24:37+00:00)
Title: commented out 1 line of code

in the _connect() method of file drivers/adodb-sybase.inc.php
there is an if block which tries to call sybase_connect() in both branches of the block.
if ($this->charSet) {} else {}

After the if/else block there is a third call to sybase_connect() which is redundant. I've simply commented out this line.

the
var $charSet declaration should be added because there is a test for the presence of this variable in the function _connect()
Maybe it is handled in the base class, maybe it's passed in as a new property by the caller, autovivified by dynamic expansion of the class.

at the top is optional.
i've set it to "iso_1" because it is reasonable for many but maybe it's not generic enough.