mleibman/SlickGrid — pull request #725 by kzhdev (2013-08-22 19:49:18+00:00)
Title: Performance Improvement

The getDataLength() and getDataLengthIncludingAddNew() are being called multiple times in some code path. For example, getDataLength get called 5 times when calling resizeCanvas() which didn't count the number it get called in the onRowChanged event in turn.

In my current project, my data came from 2 different source, each time calling getDataLength, it needs to calculate the total length. Although the calculation is not a big deal, the repeated calling could hit the performance.

Do you expecting the data length to be changed if the user didn't call UpdateRowCount? If the answer is no, I think you should have dataLength private member which is updated only when UpdateRowCount was called. Everywhere else in the code should use dataLength directly.