sergiogonzalez/liferay-portal — pull request #942 by zsigmondrab (2013-08-14 07:25:48+00:00)
Title: LPS-38618 Handle Don't set cookie domain explicitly if SESSION_COOKIE_USE_FULL_HOSTNAME is enabled

Hi Sergio,

I've sent this to Julio first with the same message below, because he took part in our discussion about this problem. I have to send this again because it failed on a test previously.

I really don't know to whom I should send this to. Minhchau is in the CookieKeys class as an author, however, he's not on our review chain.

I chose you as you're familiar with this issue already, but please, feel free to pass or let me know who else I should send to.

One question. Shouldn't we check the PropsValues.SESSION_COOKIE_DOMAIN property in the HttpImpl class also before the check of PropsValues.SESSION_COOKIE_USE_FULL_HOSTNAME?

Thank you,
Zsigmond