AwfulDevs/Something-Awful-Android — pull request #225 by Geekner (2013-08-09 08:43:21+00:00)
Title: Convert almost every network task to volley requests.

That was a lot of work. This converts almost everything to requests, and various improvements to the request system itself.

This is going to need a ton of regression testing, it's pretty stable so we should be able to push to the beta users right now.

One additional major change, as I was looking through the reply code it was obvious that the current reply saving/sending/DB shit was complete trash. I ditched the ugliest parts of it and it's simpler now, but the save-restore message function is currently disabled. I'm going to redesign it so it saves to the DB only when it needs to persist because of exit/failure, during normal use the reply will never touch the DB. I also want to kill that saved message popup and replace with an inline message/button above the text, so it's way less intrusive and confusing.

Tasks that have NOT been converted:
redirect task - Because I don't see an easy way of replicating this in volley. I'll probably break out this little bit of code and handle it elsewhere so we can completely kill the syncservice.

Send PM task - I converted the fetch pm/list tasks because they were easy, but the PM-send task will need the same kind of rewrite as the post/quote/edit stuff got.

Trim DB task - Volley isn't the right context to do this, originally I made it a task so it'll be easy to trigger off another task. This will need to move to a different context, we might even be able to restructure it out altogether. I don't even know how relevant it is anymore.

So, yea, pretty much consider this done. Volley ho.