liferay/liferay-portal — pull request #416 by vilmospapp (2013-08-07 10:26:32+00:00)
Title: [TECHNICAL SUPPORT] LPS-38482 Added getRegularURL() to LayoutRevisionImpl

Hi Máté,

This issue is about add the getRegularURL() method implementation to LayoutRevision, so the fresh version's settings take account when NavItem calls _layout.getRegularURL(). Without this fix, the Proxy object returns the LayoutImpl's getRegularURL() with previous data.

I had some issues with the method parameter passing as from NavItem we have ProtectedServletRequest gut getRegularURL() requires HttpServletRequest in LayoutImpl, so I tried this footprint first in LayoutRevisionImpl. Unfortunately the reflection API didn't find the method as the passed parameter is a ProtectedServletRequest. I've tried casting with no success, hence I changed the method parameter type in the newly added method to require ProtectedServletRequest instead of HttpServletRequest.

I've already talked about it with @juliocamarero and @topolik and tried their suggestions but the reflection API related issue still persisted.

Please review this, if you can think of a more elegant/proper way to do it please go ahead with it.

Regards,
Vilmos