jbosstools/jbosstools-server — pull request #127 by robstryker (2013-08-06 16:54:49+00:00)
Title: JBIDE-14818 - moderate refactor to allow openshift to use the composite ...

...for customizing deployment names

The server editor's deployments page consists of 3 moving parts:
1) the 'page' itself
2) a "composite assistant" to make the various controls (deloy folder, tmp deploy folder, deploymenttype:server/metadata/custom)
3) the same composite assistant to make the viewer for customizing modules' deploy names

The assistant was basically a poorly-made internal utility class and it was not a composite on its own. The workflow was poor and hard to follow. This patch splits it up now into:
1) The page
2) the "composite assistant" to make the top-level items (deloy folder, tmp deploy folder, deploymenttype:server/metadata/custom)
3) A new actual composite to show the viewer

Unfortunately the composite assistant could not be changed to a composite immediately because it still uses a hack interface (which is used by rse.ui) for gathering the remote server home, configuration, etc. Until those APIs are cleaned up, this will have to suffice as a first pass. Cleaning up those interfaces are a clear issue that is already prioritized very highly (because enabling remote deployment scanners needs it), but it is not part of this specific jira. Since the hack interface is in .ui classes, but its replacement will be in .core, it would be impossible to fix the interface issue first.