cms-sw/cmssw — pull request #240 by wmtan (2013-08-05 21:47:30+00:00)
Title: comment out unneeded function

FWCoreParameterset has two functions named getParameterSetNames. The function taking one argument has several problems: 1) It is not marked const even though it is really a const function, 2) It can be confused with the function taking two arguments, because the two argument function has a default for the second argument.

The two argument function with the second argument defaulted returns the names of all tracked parameters in the parameter set, while the one argument function returns the names of all parameters, tracked and untracked. However a case by case study of every use of the function taking one argument shows that, in every case, the two argument function can be used instead, because only the names of tracked parameters are needed.

Therefore, this pull request removes the unneeded one argument function, by commenting it out. Inside the comment, the function is made const and renamed to getAllParameterSetNames, just in case it is ever needed in the future.