atheme/atheme — pull request #174 by mescam (2013-07-27 15:35:02+00:00)
Title: patch for unreal's umode +r when using esvid

I've noticed strange behaviour of Atheme login and nick change handling when using UnrealIRCd 3.2 with ESVID support.

Based on nenolod's comment from unreal's bugtracker (http://bugs.unrealircd.org/view.php?id=4083)
>The baseline recommendation for legacy IRCd software which has had a registered usermode is to continue to support the registered usermode and send +r/-r when the account is authenticated *and* on an owned nick.
>If the account is authenticated, but the nickname is not owned by that account, then only the accountname should be sent in WHOIS. This is the current behaviour of Atheme -- I do not know what Anope's behaviour is.

But it is not the current behaviour.

Whenever I identify myself from an unregistered nick (eg. as Guest213123 /ns identify myuser pass) I get +r. Moreover, whenever I change my nickname (to registered) I do not recieve +r back. In both of those cases the actual atheme's behaviour differs from my expectations.

I don't know if I'm correct, so please review the patch I've attached.

Best regards!