puppetlabs/packaging — pull request #169 by MosesMendoza (2013-07-22 21:28:13+00:00)
Title: Maint/master/cleanup job after success

This PR includes 3 changes to the packaging repo:

Part 1 is the result of going over the packaging repo from start to finish
and searching out all the places where we don't fail that we should. The repo
creation tasks are an example of this - we shouldn't just accept when there are
no files to create repos from - if this has happened, it is almost certainly an
error, and the result should indicate it. This is more important now than ever
because jenkins is doing most of the work, and we're only paying attention when
we see a job failure. The `fail` method almost completely replaces all existing
exit lines, mostly because the exit codes were largely inconsistent and
undocumented, and thus useless. Various other cleanups are done, including
hiding much of the rarely used "remote:" tasks, and removing conditionals that
check for a '.packaging' file we stopped using long ago. Also the
pre_tasks.rake file is removed, because it is completely empty. How did it get
added? Another change this PR makes is to add "set -e" to all of the shell
execs in the templates, because jenkins won't fail a job because of a failed
rake task, which we need, now that our rake tasks are failing.

Part 2: Delete packaging job after repo job has succeeded
This commit deletes the packaging job after the repos have been created. This
will help us avoid running out of space on the jenkins master as well as reduce
clutter before the jobs get cleaned up.

Part 3: Add single quotes to downstream uri
We take the downstream uri and place it in the downstream.xml job, but because
it could have ampersands, we have to use single quotes around the curl call.
Its never easy though, and this is no exception. Because we're dealing with the
xml standard, we have to use ' as opposed to ' for html.