twall/jna — pull request #250 by quipsy-karg (2013-07-21 16:25:06+00:00)
Title: Preview of contribution / More .ini APIs (nearly completes set of PrivateProfile API)

To extend and nearly complete Win32's PrivateProfile API, our company likes to contribute these missing mappings. The code origins from a commercial project and was backported into JNA with respect to your licence. We send this preview, because we have the following problems and like to get your opinion how to go on now:
* Rewritten from Java 7 to Java 6: The code origins from Java 7 and we have rewritten it to Java 6. The original code worked perfectly in our commercial product, but we are not certain whether we did a (possibly hidden) mistake when rewriting it for Java 6. As we already spend one day for writing the code from scratch again, we hope that you don't mind that we want you to double-check that it looks "correct" on Java 6.
* Use of JUnit 4.11 including Hamcrest. The original code was tested using Java 4.11 including Hamcrest. Hence, all tests we provide do not compile in the JNA environment. Be assured, they all pass in the original environment, so actually you could just throw them away ;-) but certainly this is neither a professional or safe option. As we do not have any more sponsored time for "backporting" for really outdated JUnit 3.8.1 or getting rid of Hamcrest, we have provided the needed libraries as markers in the lib folder and kindly ask to migrate JNA to 4.11 -- as it makes contributing to JNA so much easier. See, we are currently refactoring many more contributions from our original code to the JNA environment, and all that tests are using JUnit 4.11 / Hamcrest, so sticking with 3.8.1 means either dropping the tests or investing days into rewrites (which WE don't have any benefit of).

We're hopeing that you find a wise and fair answer, so we can go on and contribute more code. Please understand that days of backports and rewrites are out of scope of our sponsored budget for the JNA project, but one the other hand, we really would love to give away all that code we developed in the past to the JNA project.