ahornung/nao_robot — pull request #1 by miguelsdc (2013-07-19 18:06:16+00:00)
Title: Many minor improvements for nao_driver scripts

Hello!

Sorry I haven't contributed in a long time. These last few days I've had a bit of free time so I've fixed longstanding issues in the modules I wrote for nao_driver.

There are many changes (you can read the commit logs), but the highlights are the topics no longer start with the name of the node (following the convention on the rest of nao_driver), nao_leds now follows the regular usage of std_msgs/ColorRGBA and I've fixed a potential race condition in nao_behaviors when the task was preempted before it started executing.

The API remains stable except for the fact that RunBehavior.action no longer has a boolean for return value (it is understood that if the action has succeeded it has run, otherwise it's set to preempted or aborted).

Hope this is useful, and tell me if you have any comments about the patches :)

Many thanks,
Miguel S.

PS. I'm preparing another patch for nao_controllers, but since it's more critical I want to test it a bit before I propose to merge it.