pardom/ActiveAndroid — pull request #96 by markuspfeiffer (2013-07-13 17:50:18+00:00)
Title: Do not assume that toString() for an entity has not been overwritten.

I found this issue while debugging my code and was confused why .toString() kept being called on my objects. I usually overwrite .toString() to return some sensible representation of my objects which is useful while debugging. This also means that .toString() can be quite slow or cause null-reference exceptions at some points.

The Cache class currently uses the .toString() method as the key when adding it to the entity cache and 'getTableName(type) + "@" + id' on look-up.

This assumes that .toString() and the concatenated string are always the same, which is obviously no longer the case once a derived class overwrites .toString(). This commit fixes this, by using an entity's table name and its ID as the key. This should keep others (like me :) from unintentionally breaking caching.

The look-up will still fail once an entity has been persisted (which causes its ID to change from NULL to some number), is this intended? (Sorry, haven't had time to dig deeper, maybe I'm missing something).