crowbar/barclamp-crowbar — pull request #602 by cloudedge (2013-07-13 21:46:26+00:00)
Title: BDD refactor complete - all tests passing [1/1]

This pull completes the major refactor of the BDD infrastructure with the following features
1) use of erlang records instead of adhoc tuples
2) removal of old Config bag from steps
3) introduction of simpler bdd_crud abstraction layer

There are still places to cleanup and correct - many tests are still disabled.

The cleanup includes changing the User model/controller to use the new object format.
To accomplish this, I removed the UI for the user form and some of the lock/admin flags.
I am not sure if these should be put back - last discussion was to use PUT User for that instead.

Also of note:
1) I removed the hack in the node controller that ran jig.add_node. This is done in the node model

BDD/barclamp.erl | 2 +-
BDD/bdd.erl | 25 +-
BDD/bdd.hrl | 3 +
BDD/bdd_catchall.erl | 11 +-
BDD/bdd_crud.erl | 24 +-
BDD/bdd_restrat.erl | 15 +-
BDD/bdd_utils.erl | 7 +-
BDD/bdd_webrat.erl | 22 +-
BDD/crowbar.erl | 64 ++-
BDD/crowbar_rest.erl | 21 +-
BDD/deployment.erl | 2 +-
BDD/eurl.erl | 20 +-
BDD/features/jig.feature | 32 +-
BDD/features/navigation.feature | 1 -
BDD/features/node.feature | 24 +-
BDD/features/scaffolds.feature | 2 -
BDD/features/user.feature | 143 ++++++
BDD/features/users.feature | 137 ------
BDD/groups.erl | 46 --
BDD/jig.erl | 89 ++--
BDD/node.erl | 56 +--
BDD/support.erl | 23 +-
BDD/user_cb.erl | 174 +++++++
BDD/users.erl | 207 ---------
.../app/controllers/application_controller.rb | 2 +-
.../app/controllers/crowbar_controller.rb | 18 +-
.../app/controllers/cycles_controller.rb | 19 +
.../app/controllers/nodes_controller.rb | 479 ++++++++++----------
.../app/controllers/users_controller.rb | 176 ++-----
.../app/models/barclamp_crowbar/jig.rb | 24 +-
crowbar_framework/app/models/jig.rb | 8 +-
crowbar_framework/app/models/node.rb | 9 +-
crowbar_framework/app/models/node_role.rb | 230 +++++-----
crowbar_framework/app/models/role.rb | 31 +-
crowbar_framework/app/views/users/index.html.haml | 104 ++---
crowbar_framework/test/test_helper.rb | 1 +
crowbar_framework/test/unit/node_model_test.rb | 2 +
script/roles/crowbar/001_ping.sh | 2 +
38 files changed, 1018 insertions(+), 1237 deletions(-)

Crowbar-Pull-ID: c124ba733a2a2ab82512e574af1791205952445b

Crowbar-Release: development