geotools/geotools — pull request #228 by GeoffWilliams (2013-07-13 11:42:28+00:00)
Title: GEOT-4510 -- app-schema plugin should provide option to pass max features count through to SQL

Hi Rini,

Here's a pull request that addresses GEOT-4510. I just have to do the documentation and schema update for geoserver now.

Your instructions were mostly on the the money -- there was just a bit of code in DataAccessMappingFeatureIterator that was resetting my query limit away that I had to get rid of.

I've put the test for isDenormalised as one of the first actions in MappingFeatureIteratorFactory.getInstance() so its not just applied for jdbc (for consistency and so my unit tests can work properly).

Once I'd done this I had to update the roadsegments.xml mapping file for AppSchemaDataAccessTest to set isDenormalised=false otherwise its maxFeatures are reset to Integer.MAX_VALUE when the testWithConfig() test runs. -- Hope this is OK?

All app-schema unit tests in geotools pass with this changeset.

Let me know how this looks. Cheers,
Geoff