ding2tal/ddbasic — pull request #9 by kasperg (2013-07-05 09:03:34+00:00)
Title: Code review

Lots of changes, comments and questions here.

My general impression is that there is a lot of code here. Theming is not my core competency but I can't help but wonder if it could be done in another way.

* Some templates seem to have very few changes compared to the default. Could these changes be handled in a better way?
* There is a lot of cleanup code in the theme. Could this be added by using a module or a base theme instead?
* If we go with many template files it would be nice to know why they are needed. Some seem very well documented. Others not so much.